dapphub/dapptools

Normalize values used to represent true with boolean-esque env vars

Open

#810 opened on Sep 22, 2021

View on GitHub
 (1 comment) (4 reactions) (0 assignees)Haskell (323 forks)batch import
good first issue

Repository metrics

Stars
 (2,125 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Right now env vars that accept boolean-esque values (like DAPP_TEST_FFI, HEVM_RPC, and DAPP_BUILD_OPTIMIZE) each require slightly different values to represent true.

Sometimes 1 means true, sometimes yes means true, sometimes any non 0 value means true, and sometimes the variable being set at all means true!

Ideally all boolean-esque env vars would only accept one of these values to mean true, which would make using them a lot less confusing :p

Contributor guide

Research direction
Identify all environment variables that accept boolean like values (e.g., DAPP TEST FFI, HEVM RPC, DAPP BUILD OPTIMIZE) and document their current true representations. Then propose a unified standard (e.g., only accept '1' or 'true') and implement the change across the codebase.
Tech stack
None
Domain
clidevops
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Haskell (basic)Shell scripting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60