daphne-project/daphne

Unary not operator in DaphneDSL

Open

#670 opened on Feb 27, 2024

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)C++ (84 forks)auto 404
good first issue

Repository metrics

Stars
 (80 stars)
PR merge metrics
 (PR metrics pending)

Description

DaphneDSL does not support the typical unary not operator yet; one cannot say, e.g., if(!found) ... or while(!(converged || aborted)) .... There is a workaround: if(found == false), but we should not require that, since it's quite inconvenient.

Solving this issue requires:

  • changes to the DaphneDSL parser
  • a new elementwise unary operator for not
  • adding some script-level test cases

Contributor guide

Research direction
Study the DaphneDSL parser (likely in C++) to understand how existing unary operators (e.g., negation) are implemented. Implement a new unary 'not' token and AST node, then add parsing rules. Follow the pattern of existing elementwise unary operators. Write script level test cases for various uses of 'not' (if, while, etc.).
Tech stack
cpp
Domain
backendcompilers
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++parsingcompiler basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40