danielebogo/DBCamera

Issues with Camera Crop Segue

Open

#147 opened on Mar 19, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Objective-C (256 forks)github user discovery
Hacktoberfest

Repository metrics

Stars
 (1,258 stars)
PR merge metrics
 (PR metrics pending)

Description

Having an issue setting the crop view. When I call:

CGFloat width = [[UIScreen mainScreen]bounds].size.width; segue.cropRect = (CGRect){ 0, 0, width, width};

The view is never set to the mainScreen width. But If I hard code values example: segue.cropRect = (CGRect){ 0, 0, 200, 400}. Then it works. Am I doing something wrong? I'm running the camera on a 6 plus so I need the crop view to adjust to the screen width to create a square.

Contributor guide

Research direction
Check the implementation of the cropRect setter in the segue class; verify if there is any validation or casting issue when using a dynamically computed value from screen width. Also test with different screen sizes.
Tech stack
objective c
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
iOSObjective C
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70