dandavison/delta

馃殌 Indicate submodule dirty state

Open

#1,838 opened on Sep 1, 2024

View on GitHub
聽(0 comments)聽(0 reactions)聽(0 assignees)Rust聽(30,799 stars)聽(532 forks)batch import
good first issue

Description

It might be nice to indicate that submodules are "dirty" rather than showing red and green with the same commit hash.

Contributor guide

Tech stack
rust
Domain
clideveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Rustgit submodulesdelta codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Explore delta's source code to understand how it currently displays submodule diffs. Look for the parsing of `git diff` output, likely in the `src` directory (e.g., `src/diff.rs` or `src/paint.rs`). To detect dirty submodules, consider using `git diff submodule` or parsing the submodule status from the diff output. Then implement a visual indicator (e.g., color change or symbol) when the submodule is dirty. Since this is a feature request with no maintainer feedback, it may require opening a discussion to align on the exact behavior.