d4rken-org/reddit-android-appstore

Wanted: Unit tests of all sorts

Open

#58 opened on Sep 19, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (54 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (377 stars)
PR merge metrics
 (PR metrics pending)

Description

To test:

  • Presenter (e.g. lifecycle behavior and callbacks)
  • Data sources (e.g. caching behavior)
  • Parsers (e.g. correctly parsing and dealing with edge cases)

The tools of choice:

  • Mockito
  • Robolectric (if necessary)

Style:

  • Unit tests belong in src/test/...
  • Test classes should follow the package structure as the classes they want to test.
  • Test classes should have the same name as their test target, just postfixed with "Test".
  • Method names testMethodToTest for basic behavior and testMethodToTest_forSpecificCases

Contributor guide

Research direction
Identify the classes in the presenter, data source, and parser packages. Write unit tests using Mockito for mocking dependencies and Robolectric if Android framework dependencies are needed. Follow the existing test structure: place tests in src/test/..., mirror the source package, name test classes with 'Test' suffix, and use descriptive method names like 'testMethodToTest' or 'testMethodToTest forSpecificCases'. Start with a simple unit test for a presenter method, then expand to data sources and parsers.
Tech stack
javaandroid
Domain
mobile
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaAndroid testing basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70