d0c-s4vage/pfp

First example in getting started doc has invalid syntax

Open

#48 opened on Jan 25, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (37 forks)github user discovery
buggood first issue

Repository metrics

Stars
 (203 stars)
PR merge metrics
 (PR metrics pending)

Description

while(!FEof()) {
    Printf("Parsing the %d-th TLV structure", ++count);
    struct {
        string type;
        int length;
        char value[length;
    } tlv;
}

the char value[length; line is missing the ending ]

Contributor guide

Research direction
Fix the missing closing bracket in the code example by adding ']' after 'length'.
Tech stack
python
Domain
documentation
Issue type
Documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
95