d0c-s4vage/pfp

Charsets are unimplemented

Open

#39 opened on Sep 14, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (37 forks)github user discovery
buggood first issue

Repository metrics

Stars
 (203 stars)
PR merge metrics
 (PR metrics pending)

Description

The actual line I had was like that: StringToWString(value,CHARSET_JAPANESE), and CHARSET_JAPANESE was reported as undefined.

It should also be noted that the following implicit cast to utf-8 is valid:

local string out;
SPrintf(out,"%s",StringToWString(value,CHARSET_JAPANESE));

Contributor guide

Research direction
Locate where charset constants are defined (likely in pfp/charsets.py or similar), check if CHARSET JAPANESE is missing, add the constant with appropriate encoding mapping, and verify that the implicit cast to UTF 8 works as shown in the issue.
Tech stack
python
Domain
backendtooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70