cube-js/cube

@cubejs-client/core load method error does not contain HTTP error code

Open

#833 opened on Jul 14, 2020

View on GitHub
 (4 comments) (6 reactions) (0 assignees)Rust (19,563 stars) (1,965 forks)batch import
client:corehelp wanted

Description

Describe the bug In @cubejs-client/core, when an errors occurs, there is no way to get errors the HTTP error code.

To Reproduce

  1. Make a request using @cubejs-client/core like this
const makeQuery = async () => {
  const cubejsApi = cubejs(
    'CUBEJS-API-TOKEN',
    { apiUrl: 'http://localhost:4000/cubejs-api/v1' }
  );

  try {
    const response = await cubejsApi.load(query);
    return response.chartPivot();
  } catch (error) {
    console.log(error);
  }
}
  1. error in the catch block does not contain http error code

Expected behavior error should contain the HTTP error code

Version: ^0.15.4

Additional context

Contributor guide

Tech stack
javascripttypescript
Domain
apideveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptHTTP basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The error object in the catch block does not include the HTTP status code. Look at the `load` method in the client code (likely in `packages/cubejs client core/src/index.js` or similar). The error is likely thrown from an HTTP request; ensure the response status is passed to the error. Check the error handling logic and modify it to include `error.httpStatus` or similar. See also related comments in the issue for additional context.