cube-js/cube

There should be a way to cancel the requests from useCubeQuery when the component has unmounted

Open

#8263 opened on May 15, 2024

View on GitHub
 (3 comments) (3 reactions) (0 assignees)Rust (19,563 stars) (1,965 forks)batch import
client:coreclient:reacthelp wanted

Description

When we are using the useCubeQuery hook to get the data from cube server & user has routed to some other routes, while the result is being fetched. Then it should cancel out the request , as component from which the request was raised has already unmounted

To Reproduce Steps to reproduce the behavior:

  1. create a dashboard with multiple reports on it
  2. redirect to another route as soon as you have landed on dashboard
  3. In network tab of developer tool, you will see that the requests of reports on dashboard are still active, which is of no use now, as the dashboard component has already unmounted

Expected behavior Requests for reports data should have be cancelled out

Contributor guide

Tech stack
reactjavascripttypescript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
React hooksJavaScript async/await
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue requests that useCubeQuery cancel pending requests on component unmount. The fix likely involves adding an AbortController or similar mechanism within the hook. Look at the source code in packages/cubejs react/src/hooks/ or similar. There are 3 comments and no open PRs. Check if maintainers have provided any guidance in comments. The expected behavior is clear, but the exact implementation may need approval.