Migrate away from `request` and `request-promise` · cube-js/cube#8204

2024-04-29T20:01:46.000Z

[request](https://classic.yarnpkg.com/en/package/request) and therefore [request-promise](https://www.npmjs.com/package/request-promise) have been deprecated for a while. On top of that they are dependent on an old version of `tough-cookie` for which there is a critical CVE report (CVE-2023-26136). migrating to a different request tool is highly recommended for: - https://github.com/cube-js/cube/blob/e5d20d228ac07849dbcd4df2f713ea01fc74f0fe/packages/cubejs-backend-cloud/package.json#L29 - https://github.com/cube-js/cube/blob/e5d20d228ac07849dbcd4df2f713ea01fc74f0fe/packages/cubejs-cli/package.json#L44 - https://github.com/cube-js/cube/blob/e5d20d228ac07849dbcd4df2f713ea01fc74f0fe/packages/cubejs-schema-compiler/package.json#L81

(2 comments) (0 reactions) (0 assignees)Rust (19,563 stars) (1,965 forks)batch import

help wanted

Description

request and therefore request-promise have been deprecated for a while. On top of that they are dependent on an old version of tough-cookie for which there is a critical CVE report (CVE-2023-26136). migrating to a different request tool is highly recommended for:

https://github.com/cube-js/cube/blob/e5d20d228ac07849dbcd4df2f713ea01fc74f0fe/packages/cubejs-backend-cloud/package.json#L29
https://github.com/cube-js/cube/blob/e5d20d228ac07849dbcd4df2f713ea01fc74f0fe/packages/cubejs-cli/package.json#L44
https://github.com/cube-js/cube/blob/e5d20d228ac07849dbcd4df2f713ea01fc74f0fe/packages/cubejs-schema-compiler/package.json#L81

Contributor guide

Tech stack: javascriptnodejs
Domain: backend
Issue type: refactor
Difficulty: 3
Estimated time: 1-3 hours
Activity status: stale
Clarity: clear
Prerequisites: Node.js basicsnpmHTTP client knowledge
Newbie friendliness: 60
Research direction: Replace the 'request' and 'request promise' packages with a modern alternative (e.g., node fetch or axios) in the three packages listed: cubejs backend cloud, cubejs cli, and cubejs schema compiler. Update all import/require statements and usage patterns. Ensure tests pass. Check for any other dependencies that might be affected.