cube-js/cube

`chartPivot` and `tablePivot` methods of `ResultSet` don't throw error for un-decomposed datasets of `compareDateRange` type queries

Open

#8050 opened on Mar 28, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (19,563 stars) (1,965 forks)batch import
client:coregood first issuehelp wanted

Description

Describe the bug If you run a compareDateRange query, you will get a result set that needs to be "decomposed" first using the decompose method of the client library. Calling the rawData method on it would correctly emit this error:

Error: Method is not supported for a 'compareDateRangeQuery' query type. Please use decompose

However, calling tablePivot and chartPivot would not emit any errors—which is quite confusing for someone who doesn't know about decompose and quirks of compareDateRange.

Expected behavior Calling tablePivot and chartPivot on compareDateRange result set should emit the same error as shown above.

Version: 0.35.4

Contributor guide

Tech stack
typescriptnodejs
Domain
api
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Locate the `chartPivot` and `tablePivot` methods in the `ResultSet` class, likely in `packages/cubejs client core/src/ResultSet.ts`. Notice that `rawData` already throws an error for `compareDateRange` queries. Replicate that error checking logic in `chartPivot` and `tablePivot` with the same error message. Verify by running existing tests and add a test case if needed.