cube-js/cube

Continue wait for GraphQL responses with http status code 500.

Open

#6,651 opened on May 24, 2023

View on GitHubContributor guide
 (4 comments) (2 reactions) (1 assignee)Rust (1,965 forks)batch import
api:graphqlhelp wanted

Repository metrics

Stars
 (19,563 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the bug Continue wait error for GraphQL responses with http status code 500.

To Reproduce Steps to reproduce the behavior:

  1. Make a graphql query which would take more than 5 seconds (or reduce continueWait time configuration).

Expected behavior Though, we don't have this documented for graphql. for rest api it is documented to return with 200. Can we please have same http status code for graphql also. https://cube.dev/docs/http-api/rest/#prerequisites-continue-wait

Additional context From Slack thread- https://cube-js.slack.com/archives/C04NYBJP7RQ/p1684846190185819

@vasilev-alex

Contributor guide

Research direction
Investigate the GraphQL response handler in Cube.js and ensure that continue wait responses return HTTP 200 instead of 500 for GraphQL endpoints, similar to REST API behavior.
Tech stack
None
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GraphQLHTTP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70