cube-js/cube

Extra brackets need to be specified when using dynamic measures

Open

#6,064 opened on Jan 26, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (1,965 forks)batch import
help wanted

Repository metrics

Stars
 (19,563 stars)
PR merge metrics
 (Avg merge 5d 16h) (138 merged PRs in 30d)

Description

Is your feature request related to a problem? Please describe. Example of schema:

"sales":{
   "sql":"sum(${CUBE}."Sales")"
},
"wholesaleCost":{
   "sql":"sum(${CUBE}."WholesaleCost")"
},
"profit":{
   "sql":"${sales} - ${wholesaleCost}"
},
"someCoef":{
   "sql":"${profit} / ${sales}"
}

This schema is not working. someCoef generates wrong formula${sales} - ${wholesaleCost}/${sales} while correct is (${sales} - ${wholesaleCost})/${sales} It can be fixed in 2 ways:

  1. someCoef sql should be (${profit}) / ${sales} (profit inside brackets)
  2. profit sql should be (${sales} - ${wholesaleCost}) (whole formula inside brackets)

Describe the solution you'd like Cube should check and automatically add brackets if needed

Contributor guide

Research direction
Investigate Cube's measure reference resolution logic and add automatic parenthesis for dynamic measures.
Tech stack
javascriptsql
Domain
backenddata
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptSQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75