cube-js/cube

useCubeQuery returns stale result even if resetResultSetOnChange is set

Open

#5289 opened on Sep 13, 2022

View on GitHub
 (5 comments) (2 reactions) (0 assignees)Rust (19,563 stars) (1,965 forks)batch import
client:corehelp wanted

Description

Describe the bug Changing the query passed to useCubeQuery causes the latter to return the old value even if resetResultSetOnChange is set to true

To Reproduce Steps to reproduce the behavior:

  1. Create some query and pass it to useCubeQuery, then log both the query and the results, something like this
const result = useCubeQuery(query, { resetResultSetOnChange: true })

console.log('Test query: ', query)
console.log('Test result: ', result)
  1. Change the query in any way, eg. user interaction
  2. See logs

Expected behavior I expect the resultSet to be null if the passed query has changed (I guess isLoading should be true, either)

Screenshots You can see from the following screenshot that even though the query changed (there's a filter in the second one), the returned resultSet is the same (actually the whole object is the same), then after a third render the result is the one expected (last two lines).

image

Version: 0.30.64

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactCube.js clientJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the useCubeQuery hook implementation in the cube js/cube repository, specifically the resetResultSetOnChange logic. Look at how the hook compares queries and triggers state updates. The issue indicates that when the query changes, the old result is returned for one render before the correct result appears, suggesting a timing or caching issue. Examine the hook's effect dependencies and state management to ensure the result set is reset immediately on query change.