cube-js/cube

Schema Compiler - Column names in Hebrew: support schema generation for non ASCII table names

Open

#5,174 opened on Aug 27, 2022

View on GitHub
 (3 comments) (2 reactions) (0 assignees)Rust (1,965 forks)batch import
help wanted

Repository metrics

Stars
 (19,563 stars)
PR merge metrics
 (Avg merge 5d 16h) (138 merged PRs in 30d)

Description

Describe the bug When generating my cube with the schema compiler, column names in Hebrew letters are trimmed and a empty key dimension is generated.

To Reproduce Steps to reproduce the behavior:

  1. Generate a schema with the schema compiler in localhost:4000/playground with Hebrew column names.
  2. You'll notice that generated dimensions key's that suppose to have Hebrew letters are empty.
cube(`TableNameWithHebrewColumnName`, {
  sql: `SELECT * FROM "TableName"."TableNameWithHebrewColumnName"`,
  
  preAggregations: {
    // Pre-Aggregations definitions go here
    // Learn more here: https://cube.dev/docs/caching/pre-aggregations/getting-started  
  },
  
  joins: {
    
  },
  
  
  dimensions: {
    formNumber: {
      sql: `${CUBE}."Form_Number"`,
      type: `number`
    },
   
    : {
      sql: `${CUBE}.`,
      type: `string`,
    },
  },
  
  dataSource: `default`
});

Expected behavior To have an object with hebrew letters.

expected :  "גיל " : {
                       sql: `${CUBE}.גיל `,
                       type: `string`,
                  }

Version: @cubejs-backend/schema-compiler : 0.30.45

Contributor guide

Research direction
Investigate how the schema compiler handles non ASCII column names. Trace the code path that generates dimension keys and SQL for column names. Identify where Hebrew characters are being trimmed or dropped, and ensure proper quoting/escaping to preserve non ASCII characters.
Tech stack
javascripttypescript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75