cube-js/cube

fill missing dates with other values than zero

Open

#4,912 opened on Jul 14, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (19,563 stars) (1,965 forks)batch import
help wanted

Description

Is your feature request related to a problem? Please describe. When executing resultset.series(), fillMissingDates is true by default, and the values of the missing dates are filled with 0. In some scenarios, I have a data with 0 as values, and it makes it hard to identify which is actual date and which is missed date in the result. An ability to set the missing date's value to null or to -1 it could be useful to some charts such as nivo (in nivo value: null is considered empty)

Describe the solution you'd like

  1. Add another option missingDateValue
  2. fillMissingDate will be either boolean or an object describing { enabled: boolean, value: number | null | etc.. }

Contributor guide

Tech stack
javascripttypescript
Domain
apidata
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Cube.js JavaScript SDKUnderstanding of series() method
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the implementation of the `series()` method in the Cube.js JavaScript SDK, likely in the `ResultSet` class. Locate where `fillMissingDates` is used and where the default value of 0 is applied. Consider both proposed approaches: adding an optional `missingDateValue` parameter or changing `fillMissingDates` to accept an object. Examine existing tests for series to understand expected behavior. The codebase is in the `packages` directory of the cube js/cube repository.