cube-js/cube

Support percents that are not multiplied by 100.

Open

#4565 opened on May 19, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (19,563 stars) (1,965 forks)batch import
help wantedloggedreviewed

Description

Generally, I want to handle formatting in the front-end code, not in Cube. For instance, if I want to display a number as a percentage in a table, then Cube will provide a ratio measure, and I'll turn it into a percentage string in the table column definition using Intl.NumberFormat. In particular, I expect Cube to provide a raw ratio, not a ratio multiplied by 100. This is consistent with the behavior of both Intl.NumberFormat and Excel, which will both turn .1 into 10% and 10 into 1000%.

However, Cube's percent formatter will format .1 as 0.10% rather than as 10%. This causes incorrect values to be displayed in the playground.

Describe the solution you'd like

Either a new format (e.g. percentNormalized) or a configuration option indicating that percent members are not multiplied by 100.

Contributor guide

Tech stack
javascripttypescriptnodejsrust
Domain
api
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic knowledge of Cube's formatting options
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the percent formatting logic in Cube's codebase. The issue suggests that the 'percent' format currently multiplies values by 100, but should not. Look for the format handler for 'percent' in the source code (likely in JavaScript/TypeScript files) and modify it to not multiply by 100. Ensure compatibility with existing usage or add a new format option like 'percentNormalized'.