cube-js/cube

Support percents that are not multiplied by 100.

Open

#4,565 opened on May 19, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (1,965 forks)batch import
help wantedloggedreviewed

Repository metrics

Stars
 (19,563 stars)
PR merge metrics
 (Avg merge 5d 16h) (138 merged PRs in 30d)

Description

Generally, I want to handle formatting in the front-end code, not in Cube. For instance, if I want to display a number as a percentage in a table, then Cube will provide a ratio measure, and I'll turn it into a percentage string in the table column definition using Intl.NumberFormat. In particular, I expect Cube to provide a raw ratio, not a ratio multiplied by 100. This is consistent with the behavior of both Intl.NumberFormat and Excel, which will both turn .1 into 10% and 10 into 1000%.

However, Cube's percent formatter will format .1 as 0.10% rather than as 10%. This causes incorrect values to be displayed in the playground.

Describe the solution you'd like

Either a new format (e.g. percentNormalized) or a configuration option indicating that percent members are not multiplied by 100.

Contributor guide

Research direction
Investigate Cube's percentage formatting logic and implement a new format option that does not multiply by 100.
Tech stack
javascripttypescript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75