cube-js/cube

Query Builder Playground props onVizStateChanged (and other props) not working

Open

#3,694 opened on Nov 17, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (19,563 stars) (1,965 forks)batch import
help wanted

Description

Hi 👋

I'm trying to integrate the Query Builder from your playground package on my React app, but some props doesn't seem to work.

<QueryBuilder
   apiUrl={apiUrl}
   token={token}
   onTabChange={(e) => { console.log('***** tabChanged', e); }}
   onVizStateChanged={( vizState ) => { console.log('***** vizState', vizState); }}
/>

When I changed a tab it's work, but if I change my viz nothing happened. Also, some props like defaultQuery or initialVizState doesn't seem to work too.

Somebody can help me ? :) Or a full query builder already exist for React ?

My goal is to save the json on my DB for display viz later.

Thank you 🙏

Contributor guide

Tech stack
reactjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Reactcube js playground component
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Look into the source code of the QueryBuilder component in the cube js playground package (likely packages/playground/src/QueryBuilder.tsx). Examine how props like onVizStateChanged and defaultQuery are handled and whether they are properly passed to the underlying component. Check if there are any existing issues or PRs addressing this. The user may need to use a different version or there might be a bug in the prop handling. Clarify the expected behavior and suggest a fix if possible.