cube-js/cube

`shouldFetchDryRun` should consider changes made to filters

Open

#3,552 opened on Oct 18, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (19,563 stars) (1,965 forks)batch import
client:reacthelp wanted

Description

Describe the bug When I modify filters using updateFilters methods within QueryBuilder, a dry run does not occur as expected. Adding filters to the existing shouldFetchDryRun array (['measures', 'dimensions', 'timeDimensions']) fixes the issue.

To Reproduce Steps to reproduce the behavior:

  1. Call updateFilters.add QueryBuilder (@cubejs-client/react) to modify filters
  2. A dry run does not occur

Expected behavior I expect a filter change to prompt a dry run.

Screenshots https://github.com/cube-js/cube.js/blob/master/packages/cubejs-client-react/src/QueryBuilder.jsx#L485-L488

Version: 0.28.43

Additional context Add any other context about the problem here.

Contributor guide

Tech stack
javascriptreactnodejs
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
knowledge of Reactfamiliarity with cubejs client
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue is located in packages/cubejs client react/src/QueryBuilder.jsx around line 485-488. The fix is to add 'filters' to the array ['measures', 'dimensions', 'timeDimensions'] in the shouldFetchDryRun function. No additional changes are needed; it's a simple array addition.