cube-js/cube

Filter on oracle driver

Open

#3,538 opened on Oct 13, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (19,563 stars) (1,965 forks)batch import
driver:oraclehelp wanted

Description

Describe the bug when using playground react app, with oracle 18c DB, i got errors on request ' Illegal variable name/number'

To Reproduce install the cubejs playground with oracle DB

Expected behavior return request

Additional info 1- when using filter "contains", i've got || ? || unstead of || :"?" || 2- the alias generated it got used ` caracter that also generated errors 3- the connection is not closed when an error is thrown

to avoid these issues , i did a workround on updating the query variable on oracle driver and closing correctly with finally and release

Contributor guide

Tech stack
typescriptnodejsreactsql
Domain
backenddatabase
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Oracle SQL basicsNode.js environmentCube.js driver development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the Oracle driver implementation in the cube.js repository (likely under packages/cubejs oracle driver). Focus on the query building logic for filters and alias generation. Also review how connections are closed in error cases. Check if there are any existing tests for the Oracle driver to reproduce the issue.