cube-js/cube

Filter on oracle driver

Open

#3,538 opened on Oct 13, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (1,965 forks)batch import
driver:oraclehelp wanted

Repository metrics

Stars
 (19,563 stars)
PR merge metrics
 (Avg merge 5d 16h) (138 merged PRs in 30d)

Description

Describe the bug when using playground react app, with oracle 18c DB, i got errors on request ' Illegal variable name/number'

To Reproduce install the cubejs playground with oracle DB

Expected behavior return request

Additional info 1- when using filter "contains", i've got || ? || unstead of || :"?" || 2- the alias generated it got used ` caracter that also generated errors 3- the connection is not closed when an error is thrown

to avoid these issues , i did a workround on updating the query variable on oracle driver and closing correctly with finally and release

Contributor guide

Research direction
Look into the Oracle driver's query building logic, specifically how filter parameters are bound and how aliases are generated using backticks. Investigate the use of bind variables in 'contains' filters and ensure proper error handling with connection closure.
Tech stack
javascripttypescriptnodejssql
Domain
backenddatabase
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Cube.jsOracle database basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60