cube-js/cube

cubejs-elasticsearch-driver not compatible with v7.x

Open

#3,520 opened on Oct 7, 2021

View on GitHub
 (12 comments) (1 reaction) (0 assignees)Rust (1,965 forks)batch import
driver:elasticsearchhelp wanted

Repository metrics

Stars
 (19,563 stars)
PR merge metrics
 (Avg merge 5d 16h) (138 merged PRs in 30d)

Description

Describe the bug The backend package works with elasticsearch up to v6.8. With v7.x it causes the following error:

ResponseError: illegal_argument_exception
    at onBody (/cube/node_modules/@elastic/elasticsearch/lib/Transport.js:337:23)
    at IncomingMessage.onEnd (/cube/node_modules/@elastic/elasticsearch/lib/Transport.js:264:11)
    at IncomingMessage.emit (events.js:326:22)
    at endReadableNT (_stream_readable.js:1241:12)
    at processTicksAndRejections (internal/process/task_queues.js:84:21)

I've tested this behaviour both with elastic.io and a local vanilla elasticsearch v7.15 image. On the other hand, the library works correctly with elasticsearch v.6.8.18

To Reproduce Steps to reproduce the behavior:

  • Deploy elasticsearch v7.15 using docker.
  • Try to connect cube.js by following the instructions on the wiki
  • Open the cube.js schema and see the error.

Expected behavior The lib should work with the latest version of elasticsearch

Contributor guide

Research direction
Analyze the breaking changes in Elasticsearch v7.x compared to v6.x, especially in the query DSL and search response format. Then update the driver's API calls to be compatible with v7.x.
Tech stack
javascripttypescriptelasticsearch
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptNode.jsElasticsearch
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60