Using FILTER_PARAMS causes filters to be duplicated in WHERE clauses

Description

// cube.js
module.exports = {
  queryRewrite: (query, { ... }) => {
    query.filters.push({
      member: 'Order.closed',
      operator: 'equals',
      values: ['true'],
    });
    return query;
  }
};

// schema/Order.js
cube('Order, {
  sql: `SELECT * FROM order WHERE ${FILTER_PARAMS.Order.closed.filter('closed')}`,
  measures: {
    amount: {
      sql: 'amount',
      type: `sum`,
    },
  dimensions: {
    closed: {
      type: `boolean`,
      sql: `closed`,
   },
};

// query
{
  measures: 'Order.amount',
}

SELECT sum(order.amount)
FROM
  (
    SELECT *
    FROM order
    WHERE order.closed = $1
  )
WHERE
  order.closed = $2

SELECT sum(order.amount
    FROM order
    WHERE order.closed = $1

SELECT sum(order.amount)
FROM
  (
    SELECT *
    FROM order
    WHERE order.closed = $1
  )

Contributor guide

Tech stack

javascriptnodejssqlpostgresql

Domain

backendanalytics

Issue type

bug

DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.

3

Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.

1-2 days

Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.

active

ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.

mostly clear

Prerequisites

JavaScriptSQLCube.js basics

Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.

35

Research direction

Investigate the query rewriting logic in cube js/cube, specifically how `FILTER PARAMS` and `queryRewrite` interact. The bug indicates that filters added via `FILTER PARAMS` in the schema are duplicated in the subquery and outer WHERE clause. Examine the SQL generation pipeline, focusing on the `BaseQuery` and `Query` classes. Refer to the issue comments for potential root causes and maintainer insights.