cube-js/cube

Additional Filter Operators

Open

#3,369 opened on Sep 2, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (1,965 forks)batch import
api:resthelp wanted

Repository metrics

Stars
 (19,563 stars)
PR merge metrics
 (Avg merge 5d 16h) (138 merged PRs in 30d)

Description

Is your feature request related to a problem? Please describe. I'm working on an internal reporting tool and wondered about the filter operators. First of all we would like to have a inNumberRange/notInNumberRange to allow an easy filter like "invoices with a gross value between x and y" similar to the inDateRange variants. Also we would like to have a afterOrEqualDate (>=) as a variant of afterDate (>) that includes the given date in the range.

While we could reproduce the number range with the given operators gt, gte, lt, lte and the logic and/or, at the moment there is no easy way to have a >= check with dates.

Describe the solution you'd like While reading the documentation about filter operators my first thought was why there are the beforeDate and afterDate operators at all. As far as i can tell those are just lt and gt with a fancy name. It would be awesome to just be able to use gt, gte, lt, lte for dates as well as numbers, and having a new [not]between operator that replaces the date range operators and can be used with number and time?

Contributor guide

Research direction
Investigate the current filter operator implementation in Cube.js, particularly the date operators. Understand how `beforeDate` and `afterDate` are defined and consider extending them or adding new operators like `afterOrEqualDate`, `inNumberRange`, and `notInNumberRange`. Look at the existing operator definitions and test files to identify where changes should be made.
Tech stack
rust
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70