cube-js/cube

Add precommit hooks

Open

#324 opened on Dec 31, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Rust (1,965 forks)batch import
help wanted

Repository metrics

Stars
 (19,563 stars)
PR merge metrics
 (Avg merge 5d 16h) (138 merged PRs in 30d)

Description

Is your feature request related to a problem? Please describe. It would be a better developer experience if lint checks were run as a Git precommit hook, as opposed to the somewhat longer feedback loop of a CI failure.

Describe the solution you'd like Many such tools/toolchains exist on NPM, lint-staged and husky being the most popular.

lint-staged allows for linting only staged files, and husky sets up Git precommit hooks in your project.

Additionally, tools such as commitlint can be used to enforce Git commit message styles (in this case, conventional commits) while commitizen can be used to provide a CLI wizard for commit messages.

Additional context lint-staged: https://github.com/okonet/lint-staged husky: https://github.com/typicode/husky commitlint: https://github.com/conventional-changelog/commitlint commitizen: https://github.com/commitizen/cz-cli

Contributor guide