cube-js/cube

Fails to parse ES query result

Open

#3,128 opened on Jul 19, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (19,563 stars) (1,965 forks)batch import
driver:elasticsearchhelp wanted

Description

Describe the bug Cubejs fails to parse ES query result.

To Reproduce Steps to reproduce the behavior:

  1. Create a valid cube schema connecting to AWS ES 7.7
  2. Build a query using cubejs play ground with just measure and dimension
  3. Run the query
  4. See error

Expected behavior Generated SQL query from cubejs log can be copied to kibana and executed successfully. So, query result should be shown in chart.

Screenshots Screen shot attached.

Error: Cannot read property 'map' of undefined
    at QueryQueue.parseResult (/cube/node_modules/@cubejs-backend/query-orchestrator/src/orchestrator/QueryQueue.js:125:13)
    at QueryQueue.executeInQueue (/cube/node_modules/@cubejs-backend/query-orchestrator/src/orchestrator/QueryQueue.js:114:19)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at /cube/node_modules/@cubejs-backend/query-orchestrator/src/orchestrator/QueryCache.ts:330:17
    at QueryOrchestrator.fetchQuery (/cube/node_modules/@cubejs-backend/query-orchestrator/src/orchestrator/QueryOrchestrator.ts:92:20)
    at OrchestratorApi.executeQuery (/cube/node_modules/@cubejs-backend/server-core/src/core/OrchestratorApi.ts:57:20)
    at /cube/node_modules/@cubejs-backend/api-gateway/src/gateway.ts:797:26
    at async Promise.all (index 0)
    at ApiGateway.load (/cube/node_modules/@cubejs-backend/api-gateway/src/gateway.ts:782:23)
    at /cube/node_modules/@cubejs-backend/api-gateway/src/gateway.ts:281:7
Orchestrator error: 65ef53e6-1fed-4417-978d-5d36c946e066-span-1 (953ms)

Version: v0.27.53 AWS ES 7.7

Additional context Generated SQL query has be run through kibana to verify there is no issue with query.

Contributor guide

Tech stack
typescriptnodejsrest api
Domain
backendapidatabase
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptNode.jsCube.js query orchestration
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the parseResult method in QueryQueue.js line 125. The error occurs because the result object is undefined when calling .map. Check the Elasticsearch driver's response format for the case when there are no results. Consider adding a guard clause to handle undefined or non array results.