cube-js/cube

Elasticsearch - Result formatting differences

Open

#2,663 opened on May 6, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Rust (1,965 forks)batch import
community supporteddriver:elasticsearchhelp wanted

Repository metrics

Stars
 (19,563 stars)
PR merge metrics
 (Avg merge 5d 16h) (138 merged PRs in 30d)

Description

A recent change to conform with elaastic.co result formatting (to cope with json result) is not compatible with open distro/aws es sql result formatting. In open distro case, json formatting is more like the standard es result format whereas json format in elastic.co is more like a jdbc format.

This is the offending code. https://github.com/cube-js/cube.js/blob/c1e25d7184c5ed63ba083da1cd9cf0f2111b8011/packages/cubejs-elasticsearch-driver/driver/ElasticSearchDriver.js#L86

We perhaps need to split the driver in some way - either entirely or certainly the query and driver.

I am happy to look at PR for this

To Reproduce setting result format to json while using awses/open distro - json result formatting results in an exception

Expected behavior Both open distro and elastic.co should be supported either via single driver or multiple

Version: latest

Contributor guide

Research direction
Compare the result formats between elastic.co and open distro AWS ES SQL APIs, then modify the driver to handle both formats or split into separate drivers.
Tech stack
javascript
Domain
backenddatabase
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75