cube-js/cube

Mongo Query Not Generating Boolean Value

Open

#1,232 opened on Oct 21, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (1,965 forks)batch import
driver:mongodbhelp wanted

Repository metrics

Stars
 (19,563 stars)
PR merge metrics
 (Avg merge 5d 16h) (138 merged PRs in 30d)

Description

Describe the bug I am using the Vue cube.js client and I am using Mongo BI Connector as my datasource.

I have a boolean dimension in one of my cubes, but when I execute a query I get the following SQL generated:

SELECT * FROM `cube` WHERE (`cube.myBoolean` <> 'true'
	OR `cube.myBoolean` IS NULL);

Note how the value it is comparing against is 'true' and not true.

Expected behavior I expect it to generate something like:

SELECT * FROM `cube` WHERE (`cube.myBoolean` <> true
	OR `cube.myBoolean` IS NULL);

Version: 0.21.1

Additional context This is a huge issue for me because my MongoDB has an index on that field, and this causes my index to not work. Is there any temporary workaround I can do until this gets fixed?

Contributor guide

Research direction
Investigate how boolean values are formatted in SQL generation for MongoDB BI Connector. Look at filter expressions where boolean dimensions are compared, and ensure the value is not quoted.
Tech stack
javascripttypescript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptSQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65