Refactor ScoreBox to accept ScoreBoxViewState
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start by tracing ScoreBox, ScoreBoxViewState, GameData, mapToPeriodScores, and toPeriodScores through the view model and component. Decide whether the full view-state refactor or the smaller GameData change is intended, then verify that ScoreBox receives the chosen state and period scores still render correctly.
Written by the indexing model from the issue text.
Description
Ideally mapToPeriodScores should be done in the VM, and the ScoreBox component as a whole should accept ScoreBoxViewState instead of GameData. But if you don't want to refactor all of this right now we don't have to. For now, you could just make toPeriodScores a function on the GameData data class.
Originally posted by @zachseidner1 in https://github.com/cuappdev/score-android/pull/83#discussion_r2370251309
- Dominant language
- Kotlin
- Stars
- 3
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from cuappdev/score-android
-
ui bug
cuappdev/score-android#95 · 1 comment · 1 assignee ·
-
Scores Not Showing Open
Difficulty 4/5 3-5 days Newbie friendliness 25/100
cuappdev/score-android#94 ·
-
cuappdev/score-android#92 · 1 comment · 1 assignee ·
-
Difficulty 5/5 Over a week Newbie friendliness 15/100
cuappdev/score-android#87 ·
-
infra
cuappdev/score-android#81 · 2 assignees ·
All issues in cuappdev/score-android
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Richie97/track-history#325 ·
-
bug CLI documentation reliability
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
KW-related Type:bug UI / UX
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
RevenueCat/purchases-android#4299 · 1 comment ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
AAswordman/Operit#1265 · 3 comments ·