The rule for nested lists is no longer necessary
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 82/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- css
- Domain
- frontend
Research direction
Open sanitize.css at the linked lines and review the nested-list margin rule alongside the Chromium and WebKit UA stylesheet references. Remove the rule if those browser fixes cover the stated cases, then verify the stylesheet no longer contains that obsolete normalization.
Written by the indexing model from the issue text.
Description
The rule "Remove the margin on nested lists in Chrome, Edge, and Safari" appears in sanitize.css:
Since Chromium and WebKit already have that rule in their UA stylesheets, I think it can be removed.
- Chromium fixed it 1 year ago: https://github.com/chromium/chromium/blob/0fa7607bb96dc68c2d08d9920ce5da6bc4d3287a/third_party/blink/renderer/core/html/resources/html.css#L358-L365
- WebKit fixed it 3 years ago: https://github.com/WebKit/WebKit/blob/b524a4ebf3a70a7b6409c55db9eae74800721dc7/Source/WebCore/css/html.css#L308-L315
Also mentioned in https://github.com/csstools/normalize.css/issues/27.
- Dominant language
- CSS
- Stars
- 5.3k
- Forks
- 299
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from csstools/sanitize.css
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
csstools/sanitize.css#254 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 38/100
csstools/sanitize.css#253 · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 20/100
csstools/sanitize.css#251 ·
-
ui-monospace Open
Difficulty 2/5 Under an hour Newbie friendliness 52/100
csstools/sanitize.css#249 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
csstools/sanitize.css#248 · 1 reaction ·
All issues in csstools/sanitize.css
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
gitbutlerapp/gitbutler#15998 · 1 comment ·
-
t/bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
bug ready-for-dev
Difficulty 1/5 1-3 hours Newbie friendliness 90/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 92/100