cssinjs/jss

[react-jss] Observable rules/values

Open

#995 opened on Jan 20, 2019

View on GitHub
 (10 comments) (0 reactions) (0 assignees)JavaScript (7,000 stars) (434 forks)batch import
bugcomplexity:moderatehelp wanted

Description

Expected behavior: Observables should work without explicitly passing link: true as options and should be part of the static stylesheet. And no dynamic stylesheet should be generated when only observables are used.

Describe the bug: Currently, observables are part of the static sheet but the user needs to pass link: true and a dynamic sheet will also be generated.

Codesandbox link: https://codesandbox.io/s/01ro5xn32p

Versions (please complete the following information):

  • jss: 10.0.0-alpha.8

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ReactJSSobservablesCSS in JS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue reports that observables in react jss require the `link: true` option and generate a dynamic stylesheet unnecessarily. Investigate the JSS source code, particularly the handling of observables in static sheets. Look at the codesandbox link for reproduction. The fix likely involves modifying the sheet generation logic to only generate a static sheet when only observables are used and remove the need for `link: true` explicitly.