cssinjs/jss

Throw Error instead of warning when running tests

Open

#891 opened on Oct 14, 2018

View on GitHubContributor guide
 (6 comments) (0 reactions) (0 assignees)JavaScript (434 forks)batch import
help wantedideaimportant

Repository metrics

Stars
 (7,000 stars)
PR merge metrics
 (PR metrics pending)

Description

I see in the logs many warnings, which I think shouldn't be there, which means we are ignoring problems without noticing in the CI.

I am wondering if we should replace the warning when running tests with a function that throws errors so that our tests can't ignore them.

As a bonus we won't ned to rewire in so many places, but instead use expect for catching.

Contributor guide

Research direction
Investigate the warning mechanism used in tests, identify all instances where warnings are called, and replace them with a throw pattern, ensuring tests that expect warnings use try/catch.
Tech stack
javascript
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65