cssinjs/jss

UMD builds not working on import

Open

#1567 opened on Oct 21, 2021

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (7,000 stars) (434 forks)batch import
bugcomplexity:lowhelp wanted

Description

Expected behavior: I'm trying to implement react-jss via CDN. Importing the UMD build via <script> tag should work out of the box.

Describe the bug: The module does not load and the console generates the error as follows:

Uncaught ReferenceError: module is not defined
    at react-jss.min.js:6
    at react-jss.min.js:1
    at react-jss.min.js:1

Reproduction:

CodeSandbox - loading react, react-dom, and react-jss

Versions:

  • jss: 10.8.1
  • browser: any

Contributor guide

Tech stack
javascriptreact
Domain
frontendbuild system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of UMD module formatBasic bundler configuration knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue is that the UMD bundle for react jss references `module` which is not defined in the browser. Investigate the Rollup configuration (likely `rollup.config.js` or `package.json` build scripts) to see how the UMD output is generated. Look for any missing `output.globals` or improper use of CommonJS. The fix may involve ensuring the bundle does not depend on `module` or adding a shim. Check the existing build setup and compare with other packages that successfully produce UMD bundles.