cssinjs/jss

Performance issue when removing many nodes

Open

#1404 opened on Oct 8, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (7,000 stars) (434 forks)batch import
help wantedperf

Description

Hello, I noticed that when using with React, JSS causes a lag when removing many nodes. This is screenshot when removing 80 000 nodes.

Versions (please complete the following information):

  • jss: 10.4.0
  • Browser: Chrome
  • OS: macOS

Contributor guide

Tech stack
javascriptreact
Domain
frontendperformance
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
familiarity with JSS librarybasic React performance knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Profile the removal operation to identify the bottleneck. Focus on JSS's internal handling of style removal, particularly the `remove` or `detach` methods. Consider using React Profiler to measure component re renders. Check if the issue persists in the latest version of JSS.