cssinjs/jss

Cannot use function values or function rules in TypeScript

Open

#1,342 opened on May 7, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (7,000 stars) (434 forks)batch import
help wantedtypescript

Description

Expected behavior: Function values and function rules should render the appropriate CSS.

Describe the bug: The rule which includes a function does not render. This is the typescript error (for function rules)

Index signature is missing in type '(data: any) => { backgroundColor: any; width: number; height: number; }'

Codesandbox link: Please create a codesandbox.io with the issue. Make it as minimal as possible as this will help us find the bug quicker.

https://codesandbox.io/s/nifty-visvesvaraya-7eq2v?file=/src/index.ts

Versions (please complete the following information):

  • jss: 10.1.1
  • jss-plugin-camel-case: 10.1.1
  • Browser [e.g. chrome, safari]:
  • OS [e.g. Windows, macOS]: Windows 10 (Also present in CodeSandbox) Feel free to add any additional versions which you may think are relevant to the bug.

Contributor guide

Tech stack
typescriptjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
TypeScript basicsunderstanding of JSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The issue is a TypeScript type error when using function values or function rules in JSS. The fix likely requires updating the type definitions in the jss repository, specifically in `jss plugin camel case` or core types. Check the `index.d.ts` files for type definitions that restrict style values to objects instead of functions. The provided CodeSandbox reproduces the error. The solution should allow functions that return style objects to be accepted as valid types.
Cannot use function values or function rules in TypeScript · cssinjs/jss#1342 | Good First Issue