cssinjs/jss

Global SheetsRegistry leaks memory?

Open

#1,340 opened on May 3, 2020

View on GitHub
 (0 comments) (1 reaction) (0 assignees)JavaScript (434 forks)batch import
help wantedperf

Repository metrics

Stars
 (7,000 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Expected behavior: Created StyleSheet instances should not be retained indefinitely.

Describe the bug: StyleSheet instances are being retained inside the global SheetsRegistry.

Codesandbox link: Run the react-jss example code https://github.com/cssinjs/react-todomvc-jss.git

  1. Take memory snapshot.
  2. Add a few items.
  3. Delete those items.
  4. Repeat step 2 and 3 a few more times.
  5. Take another memory snapshot.
  6. Filter both snapshots by constructor named StyleSheet and you'll find the number only grows.

Versions (please complete the following information):

  • jss: The example is using 6.5.0, but I believe the issue is present in all versions.
  • Browser [e.g. chrome, safari]: Chrome
  • OS [e.g. Windows, macOS]: MacOS Feel free to add any additional versions which you may think are relevant to the bug.

Contributor guide

Research direction
Look at the global SheetsRegistry in JSS to understand why StyleSheet instances are retained. Check if there is a missing cleanup or reference that prevents garbage collection after components unmount. Investigate the attach/detach lifecycle of stylesheets.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitBasic understanding of JavaScript and JSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60