cssinjs/jss

Media query styles applied only to the first element in function

Open

#1,320 opened on Mar 25, 2020

View on GitHub
 (26 comments) (6 reactions) (1 assignee)JavaScript (434 forks)batch import
feature requesthelp wanted

Repository metrics

Stars
 (7,000 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Expected behavior: when changing screen size media query in function should apply styles to all the component that uses it

Describe the bug: only the first component gets the styles of media query in function, it looks like it was introduced in 10.0.1

Codesandbox link: https://codesandbox.io/s/react-jss-playground-nwurq

Versions (please complete the following information):

  • jss:10.1.1
  • Browser saw it on chrome, havent tested others
  • OS windows10:

image

Contributor guide

Research direction
Inspect the regression between versions 10.0.0 and 10.0.1 for media query handling in JSS functions. Look at the plugin that processes media queries and ensure it applies to all components.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65