cssinjs/jss

Media query styles applied only to the first element in function

Open

#1320 opened on Mar 25, 2020

View on GitHub
 (26 comments) (6 reactions) (1 assignee)JavaScript (7,000 stars) (434 forks)batch import
feature requesthelp wanted

Description

Expected behavior: when changing screen size media query in function should apply styles to all the component that uses it

Describe the bug: only the first component gets the styles of media query in function, it looks like it was introduced in 10.0.1

Codesandbox link: https://codesandbox.io/s/react-jss-playground-nwurq

Versions (please complete the following information):

  • jss:10.1.1
  • Browser saw it on chrome, havent tested others
  • OS windows10:

image

Contributor guide

Tech stack
javascriptcssreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of jssUnderstanding of CSS media queries
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the jss source code, specifically the handling of media queries in function calls. Check the changes introduced in version 10.0.1 that might have caused this regression. Reproduce the issue using the provided CodeSandbox and examine the generated styles to understand why only the first element receives the media query styles. Look for any caching or scoping issues in the jss plugin or core logic.