cssinjs/jss

Using arrow function on jss-rtl dependent property does not works well

Open

#1,234 opened on Nov 21, 2019

View on GitHub
 (10 comments) (4 reactions) (0 assignees)JavaScript (434 forks)batch import
bughelp wanted

Repository metrics

Stars
 (7,000 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Expected behavior:

The rtl plugin should switch the styles.

Describe the bug:

The rtl plugin doesn't switch all the styles.

const useStyles = createUseStyles({
  myButton1: {
    paddingLeft: "16px" ✅
  },
  myButton2: {
    paddingRight: ({ isMobile }) => (isMobile ? 0 : "26px") ❌
  },
  myLabel: props => ({
    paddingRight: "8px" ✅
  })
});

Codesandbox link:

https://codesandbox.io/s/react-jss-playground-37lqs

Versions (please complete the following information):

  • jss: 10.0.0
  • Browser [e.g. chrome, safari]: all
  • OS [e.g. Windows, macOS]: all

First reported in https://github.com/mui-org/material-ui/issues/18477.

Contributor guide

Research direction
Inspect how the RTL plugin handles function values in JSS styles. Focus on the code that processes arrow functions and check if it correctly applies RTL transformations to all values.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactJSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50