cssinjs/jss

Property 'prop' does not exist on type 'BaseRule'

Open

#1,233 opened on Nov 20, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (7,000 stars) (434 forks)batch import
help wantedtypescript

Description

Describe the bug:

Code like this:

styleSheet.getRule('ruleName').prop('propName', propValue)

used to work perfectly fine with jss 9.x, but with v10.0.0 it fails with the following typescript error during build:

Property 'prop' does not exist on type 'Rule'. Property 'prop' does not exist on type 'BaseRule'.

Expected behavior:

No typescript compile error

Versions:

  • jss: 10.0.0
  • typescript: 3.6.4

Contributor guide

Tech stack
javascripttypescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of TypeScript type definitionsFamiliarity with JSS API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the JSS type definitions, specifically the BaseRule interface and the return type of styleSheet.getRule(). The error indicates that in version 10.0.0, the prop() method is missing from the BaseRule type. Check the pull requests or commits that introduced this change. Look for any existing discussions in the issue comments about the missing method. Consider adding the prop() method to the BaseRule interface or reviewing the type hierarchy to ensure Rule and BaseRule include the method.