cssinjs/jss

Property 'prop' does not exist on type 'BaseRule'

Open

#1,233 opened on Nov 20, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (434 forks)batch import
help wantedtypescript

Repository metrics

Stars
 (7,000 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Describe the bug:

Code like this:

styleSheet.getRule('ruleName').prop('propName', propValue)

used to work perfectly fine with jss 9.x, but with v10.0.0 it fails with the following typescript error during build:

Property 'prop' does not exist on type 'Rule'. Property 'prop' does not exist on type 'BaseRule'.

Expected behavior:

No typescript compile error

Versions:

  • jss: 10.0.0
  • typescript: 3.6.4

Contributor guide

Research direction
Investigate the TypeScript type definitions for BaseRule and Rule to ensure the 'prop' method is declared. Check if it was present in v9 and removed in v10.
Tech stack
javascripttypescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70