cssinjs/jss

react-jss: Observables issue

Open

#1193 opened on Sep 17, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (7,000 stars) (434 forks)batch import
bughelp wanted

Description

Expected behavior: Observables should not change the {link: true} to {link: false}

Describe the bug: If Observable's internal method is enumerable, then react-jss considers it a dynamic style and adds an unnecessary empty class. On the other hand, if the method is not enumerable, then the empty class is not added, but it does not link the styles and observable styles do not work.

Codesandbox link: https://codesandbox.io/s/react-jss-v1000alpha-25-observable-issue-g8998

Versions (please complete the following information):

  • jss: 10.0.0-alpha.25
  • Browser [e.g. chrome, safari]: Chrome
  • OS [e.g. Windows, macOS]: Windows

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactJSSObservables
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the interaction between react jss and observable objects. Examine the code in react jss that detects dynamic styles (likely in `useStyles` or style observation logic). The issue mentions that if observable's internal method is enumerable, an unnecessary empty class is added; if not enumerable, styles are not linked. The linked CodeSandbox should be used to reproduce. A possible fix could involve checking for observable objects differently, perhaps by using a weak map or not relying on enumerability.