cssinjs/jss

JssProvider should use jss instance's generateId method when jss is passed down to its props

Open

#1178 opened on Aug 21, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (7,000 stars) (434 forks)batch import
enhancementhelp wanted

Description

Expected behavior: JssProvider should use the jss instance's generateId method when jss is passed down to its props and generateId prop is not passed down.

Describe the bug: JssProvider creates it's own generateId method although it's already been defined in the jss instance passed in props.

Versions:

  • jss: 10.0.0-alpha.24
  • Browser [e.g. chrome, safari]: N/A
  • OS [e.g. Windows, macOS]: N/A

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactJSSJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The bug is in the JssProvider component, likely in the react jss package. The fix involves using the `generateId` method from the passed `jss` instance when no `generateId` prop is given. The file to modify is probably `packages/react jss/src/JssProvider.js`. Look for the place where `createGenerateId()` is called and conditionally use the jss instance's method.