cssinjs/jss

JssProvider should use jss instance's generateId method when jss is passed down to its props

Open

#1,178 opened on Aug 21, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (434 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (7,000 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Expected behavior: JssProvider should use the jss instance's generateId method when jss is passed down to its props and generateId prop is not passed down.

Describe the bug: JssProvider creates it's own generateId method although it's already been defined in the jss instance passed in props.

Versions:

  • jss: 10.0.0-alpha.24
  • Browser [e.g. chrome, safari]: N/A
  • OS [e.g. Windows, macOS]: N/A

Contributor guide

Research direction
Inspect the JssProvider component to see how it generates its own generateId method. Then, when a jss instance is provided via props, use its generateId method instead of creating a new one. Check the jss instance for a generateId property and override the local method.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65