cssinjs/jss

Extend function property values are converted to strings

Open

#1,134 opened on Jun 17, 2019

View on GitHub
 (0 comments) (2 reactions) (0 assignees)JavaScript (434 forks)batch import
bughelp wanted

Repository metrics

Stars
 (7,000 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Expected behavior: A clear and concise description of what you expected to happen.

const styles = {
  linkCommon: {
    color: () => "orange"
  },
  link: {
    extend: "linkCommon"
  }
};

The link should be orange.

Describe the bug: A clear and concise description of what happend instead of the expected behavior.

The function is being converted to a string before being inserted into the DOM.

image

Codesandbox link:

Playground: https://codesandbox.io/embed/core-jss-playground-ef0j4

Versions (please complete the following information):

  • jss: 10 alpha 18
  • jss-preset-default: 10 alpha 18
  • Browser Chrome 75
  • OS: OX X

Feel free to add any additional versions which you may think are relevant to the bug.

Not to be confused with https://github.com/cssinjs/jss/issues/479

Contributor guide

Research direction
Investigate how the extend property processes function values in JSS. Trace the code path from when extend is resolved to where the function should be evaluated. Check if the function is being converted to string prematurely.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75