cssinjs/jss

[react-jss]: Dynamic expanded styles are not updated correctly

Open

#1,051 opened on Mar 6, 2019

View on GitHub
 (0 comments) (2 reactions) (0 assignees)JavaScript (434 forks)batch import
bughelp wanted

Repository metrics

Stars
 (7,000 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Expected behavior: Dynamic styles should correctly override the previously applied styles.

Describe the bug: Dynamic styles did not correctly override the previously applied styles.

Codesandbox link: https://codesandbox.io/s/742q2630yj ( Click "All Borders" button to toggle between two sets of styles )

Versions (please complete the following information):

  • jss: 10.0.0-alpha.12
  • Browser [e.g. chrome, safari]: chrome
  • OS [e.g. Windows, macOS]: Windows Feel free to add any additional versions which you may think are relevant to the bug.

Contributor guide

Research direction
Review the CodeSandbox reproduction and trace how dynamic styles are merged in the JSS plugin pipeline; inspect the `createGenerateId` and style sheet management for memoization issues.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70