cssinjs/jss

[react-jss]: Dynamic expanded styles are not updated correctly

Open

#1051 opened on Mar 6, 2019

View on GitHub
 (0 comments) (2 reactions) (0 assignees)JavaScript (7,000 stars) (434 forks)batch import
bughelp wanted

Description

Expected behavior: Dynamic styles should correctly override the previously applied styles.

Describe the bug: Dynamic styles did not correctly override the previously applied styles.

Codesandbox link: https://codesandbox.io/s/742q2630yj ( Click "All Borders" button to toggle between two sets of styles )

Versions (please complete the following information):

  • jss: 10.0.0-alpha.12
  • Browser [e.g. chrome, safari]: chrome
  • OS [e.g. Windows, macOS]: Windows Feel free to add any additional versions which you may think are relevant to the bug.

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ReactJSSCSS in JS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate dynamic style update logic in react jss. The bug likely resides in the `useStyles` hook or equivalent where dynamic styles are merged. Check the codesandbox for reproduction steps. Examine how JSS handles style expansion and update lifecycle.