cssinjs/jss

[react-jss] each re-render of component appends new rule with media query

Open

#1044 opened on Feb 23, 2019

View on GitHub
 (1 comment) (3 reactions) (0 assignees)JavaScript (7,000 stars) (434 forks)batch import
bugcomplexity:highhelp wantedimportant

Description

Expected behavior: There's computed style with media query (&:hover etc..)

Describe the bug: Each re-render of component appends new rule with media query

Codesandbox link: https://codesandbox.io/s/7yxv3r5jp1 (see to console)

Versions (please complete the following information):

  • jss: 10.0.0-alpha.10
  • Browser chrome
  • OS macOS

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ReactJSS basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The bug is that each re render appends a new CSS rule with media queries instead of updating the existing one. The provided CodeSandbox reproduces the issue. To fix, investigate how react jSS handles dynamic styles and media queries in its JSS wrapper. Look at how styles are injected in the render method of the component using withStyles or createUseStyles. The duplication likely comes from the way the JSS sheet is managed when re rendering.