cssinjs/jss

[react-jss] each re-render of component appends new rule with media query

Open

#1,044 opened on Feb 23, 2019

View on GitHub
 (1 comment) (3 reactions) (0 assignees)JavaScript (434 forks)batch import
bugcomplexity:highhelp wantedimportant

Repository metrics

Stars
 (7,000 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Expected behavior: There's computed style with media query (&:hover etc..)

Describe the bug: Each re-render of component appends new rule with media query

Codesandbox link: https://codesandbox.io/s/7yxv3r5jp1 (see to console)

Versions (please complete the following information):

  • jss: 10.0.0-alpha.10
  • Browser chrome
  • OS macOS

Contributor guide

Research direction
Investigate how JSS handles media queries during re renders; check if rules are being appended instead of updated in the stylesheet.
Tech stack
javascriptreactcss
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactJSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40