cssinjs/jss

[RFC] Move to Typescript

Open

#1035 opened on Feb 15, 2019

View on GitHub
 (89 comments) (24 reactions) (0 assignees)JavaScript (7,000 stars) (434 forks)batch import
RFChelp wantedtypescript

Description

With more OS projects now planning to move to Typescript (jest, Vue.js, etc.), I think it would be time to think about doing the same. Typescript has matured and now with eslint and babel both supporting Typescript as well, it should be future proof.

Additionally, I think the tooling around Typescript (speed, autocompletion), etc. is far head of flow currently.

I would start with "rewriting" smaller packages (like css-functions and theming) in the beginning. Also, I started writing the new docs with Typescript.

Are you willing to implement it? Yes

EDIT: I started rewriting the core in my fork in Typescript as an experiment.

Contributor guide

Tech stack
typescriptjavascript
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
5
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
TypeScriptJavaScriptCSS in JS concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
10
Research direction
Examine the smaller packages mentioned (css functions, theming) to understand the current JavaScript API and structure. Review the core codebase to identify TypeScript conversion patterns. Check the author's fork for initial TypeScript experiments as a reference.