csnover/TraceKit

Fix flakey tests

Open

#77 opened on Apr 8, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,017 stars) (174 forks)batch import
bughelp wanted

Description

There are five flakey tests that have to do with ensuring the window.onerror is called and works properly. This needs to be mocked or figure out why the test occasionally hangs.

      - should pass undefined:undefined...
log: window.onerror(undefined, undefined, 1337, undefined)

log: matches test message and line number
       X should pass undefined:undefined
         Error: Timeout - Async function did not complete within 5000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL) (1)
>> Error: Timeout - Async function did not complete within 5000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL) Error: Timeout - Async function did not complete within 5000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL)
>>     at <Jasmine>
     when no 5th argument (error object)

Contributor guide

Tech stack
javascript
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScript basicsJasmine testingunderstanding of async behavior
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Investigate the test files for 'window.onerror' functionality, likely in the test suite. The issue mentions tests hang due to async timeouts, so mocking 'window.onerror' or adjusting timeout settings might fix. Look at other test patterns in the repo to see how similar async tests are handled.