crytic/slither

Constants implementing interface getters are marked as `UPPER_CASE_WITH_UNDERSCORES`

Open

#930 opened on Aug 27, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (886 forks)batch import
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (4,769 stars)
PR merge metrics
 (Avg merge 54d 9h) (2 merged PRs in 30d)

Description

interface I {
    function version() external view returns (uint256);
}

contract C is I {
    uint256 public constant override version = 1;
}

Due to the override specifier, the naming schema should not be checked at C.version.

Contributor guide

Research direction
Inspect the naming convention detection logic in Slither, particularly how it processes 'override' modifiers. Check the test cases for constant getters and see if there is a missing condition to skip the naming check for implemented interface functions.
Tech stack
python
Domain
securityblockchain
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SolidityStatic analysis concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65