crytic/slither

[Bug]: all statements with `.` are reported as external calls

Open

#2,073 opened on Aug 1, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (886 forks)batch import
buggood first issue

Repository metrics

Stars
 (4,769 stars)
PR merge metrics
 (Avg merge 54d 9h) (2 merged PRs in 30d)

Description

Describe the issue:

I ran slither . --print function-summary to view external calls for functions. The resulting "External Calls" column treats any statement with a . as an external call. This includes solidity built-ins like abi.encode, library accesses like Address.sendValue, and struct field accesses.

Code example to reproduce the issue:

git clone https://github.com/scopelift/pooltogether-governor-upgrade/
cd pooltogether-governor-upgrade
forge install
slither . --print function-summary

Version:

0.9.6

Relevant log output:

No response

Contributor guide

Research direction
Examine the code that prints the function summary output and filter out non external calls such as abi.encode, library calls, and struct field accesses. Look for a method that collects external calls and refine its logic to exclude false positives.
Tech stack
python
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonSolidity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70