crytic/slither

Inheritance printer adds unnecessary carriage return

Open

#1,835 opened on Apr 12, 2023

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Python (886 forks)batch import
good first issuehelp wanted

Repository metrics

Stars
 (4,769 stars)
PR merge metrics
 (Avg merge 54d 9h) (2 merged PRs in 30d)

Description

% cat test.sol

pragma solidity >= 0.8.19;

interface IFoo{}

contract Foo is IFoo {}

abstract contract Bar is Foo {}

interface IBaz{}

contract Baz is Bar, IBaz{}

% slither test.sol --print inheritance

+ Baz
 -> Bar, IBaz
, [Foo, IFoo]

It looks like we added unnecessary carriage return to the output at some point

Contributor guide

Research direction
Examine the inheritance printer source code to locate where an extra carriage return is appended to the output string for inherited contracts.
Tech stack
python
Domain
toolingdeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90