crytic/slither

Inheritance printer adds unnecessary carriage return

Open

#1,835 opened on Apr 12, 2023

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Python (4,769 stars) (886 forks)batch import
good first issuehelp wanted

Description

% cat test.sol

pragma solidity >= 0.8.19;

interface IFoo{}

contract Foo is IFoo {}

abstract contract Bar is Foo {}

interface IBaz{}

contract Baz is Bar, IBaz{}

% slither test.sol --print inheritance

+ Baz
 -> Bar, IBaz
, [Foo, IFoo]

It looks like we added unnecessary carriage return to the output at some point

Contributor guide

Tech stack
python
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic PythonFamiliarity with Slither's printer modules
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Investigate the inheritance printer output formatting in Slither's source code, likely in a file related to inheritance printing. Look for where the arrow and newline are added after 'Bar, IBaz' to remove the unnecessary carriage return. Refer to the linked issue and comments for context, and test with the provided Solidity sample.