crytic/slither

update register printer to consider multiple compilation units

Open

#1,780 opened on Mar 20, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (4,769 stars) (886 forks)batch import
buggood first issue

Description

register_detector applies to each compilation unit https://github.com/crytic/slither/blob/776dcab44070b2d236ae3bcf3b92f4245f14037a/slither/slither.py#L181-L189 register_printer does not and needs to be updated https://github.com/crytic/slither/blob/776dcab44070b2d236ae3bcf3b92f4245f14037a/slither/slither.py#L201-L208

Contributor guide

Tech stack
python
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic PythonUnderstanding of Slither's architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The issue points to two specific code sections in slither.py. The register detector function (lines 181-189) already iterates over compilation units, while register printer (lines 201-208) does not. To fix, modify register printer to loop over self.compilation units similar to register detector. Review the existing implementation to ensure consistency.