crytic/slither

similar variables detector is extremely slow

Open

#1,630 opened on Jan 27, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (4,769 stars) (886 forks)batch import
bughelp wanted

Description

This detector makes up the majority of runtime on large codebases

ncalls  tottime  percall  cumtime  percall filename:lineno(function)
        1    0.000    0.000   41.286   41.286 /Users/alpharush/tob/slither/slither/__main__.py:81(process_all)
        1    0.000    0.000   39.059   39.059 /Users/alpharush/tob/slither/slither/__main__.py:58(process_single)
        1    0.000    0.000   33.319   33.319 /Users/alpharush/tob/slither/slither/__main__.py:111(_process)
        1    0.000    0.000   33.317   33.317 /Users/alpharush/tob/slither/slither/slither.py:198(run_detectors)
        1    0.000    0.000   33.317   33.317 /Users/alpharush/tob/slither/slither/slither.py:204(<listcomp>)
       84    0.001    0.000   33.317    0.397 /Users/alpharush/tob/slither/slither/detectors/abstract_detector.py:176(detect)
        1    0.000    0.000   31.215   31.215 /Users/alpharush/tob/slither/slither/detectors/variables/similar_variables.py:72(_detect)

https://github.com/crytic/slither/blob/master/slither/detectors/variables/similar_variables.py#L63-L66

Contributor guide

Tech stack
python
Domain
toolingperformance
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Pythonbasic profiling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Focus on slither/detectors/variables/similar variables.py, especially lines 63-66 and the detect method. Use profiling to identify bottlenecks and consider algorithmic optimizations. Review comments for additional context.